ionic-team / ionic-plugin-keyboard

Ionic Keyboard Plugin for Cordova
Apache License 2.0
610 stars 274 forks source link

Question: OK to submit a pull request for a shrinkView method/setting? #297

Open martinmnetics opened 7 years ago

martinmnetics commented 7 years ago

Hi,

I am part of a team that are using Ionic Keyboard Plugin as part of our Cordova app. The app has been in development and being used by customers on Android devices for a few years. We are now targeting iOS devices as well and experiencing some issues with the different ways that iOS and Android handle the Webview when the keyboard is open.

I believe that the best solution to our issue is to add a shrinkView method and/or setting to the Ionic Keyboard plugin - similar to the one implemented in the Cordova Keyboard plugin ( https://github.com/cjpearson/cordova-plugin-keyboard ). Would you be open to me submitting a pull request with this extra functionality?

Regards,

Martin

mezykr commented 7 years ago

Same here, It would be helpful to have shrinkView flag for iOS ... Now I have to manually change body height on show/hide keyboard events depends on keyboard height .. It's not so elegant way ...