feat!: BREAKING Overhauls to the pub/sub system

ionic-team / ionic-portals-android

Other

4 stars 3 forks source link

feat!: BREAKING Overhauls to the pub/sub system #39

Closed Steven0351 closed 1 year ago

Steven0351 commented 1 year ago

Breaks out a separate PortalsPubSub class from PortalsPlugin to separate the event bus logic from the implementation of the Plugin
Makes PortalsPlugin useable as an instance plugin to scope events to a specific instance of PortalsPubSub
Adds the ability to scope the pubSub instance in linkMessageReceivers on PortalFragment.

Steven0351 commented 1 year ago

This PR is much in the same spirit of https://github.com/ionic-team/ionic-portals-ios/pull/71, without the changes in how subscriptions are managed.

Steven0351 commented 1 year ago

@carlpoole and I also discussed adding companion object shims back to PortalsPlugin that use PortalsPubSub.shared under the hood to avoid too much breaking. Those could then be marked as deprecated.

giralte-ionic commented 1 year ago

Added @IT-MikeS to review as I'm not comfortable commenting on the TS singleton comment

IT-MikeS commented 1 year ago

Did I miss something? There's no TS being worked on here it would seem @giralte-ionic

Steven0351 commented 1 year ago

Added @IT-MikeS to review as I'm not comfortable commenting on the TS singleton comment

The comment was regarding Kotlin and Java patterns

giralte-ionic commented 1 year ago

ok sorry I'm dumb