Closed mattmckeon closed 6 months ago
Our Android dev @carlpoole is out at the moment and is the only person who can speak intelligently on the points you've brought up. Regarding the min SDK comment, Portals follows the minimum SDK requirements of Capacitor.
Current project depends on Capacitor constraints.
PortalView requires its containing activity to implement AppCompatActivity. This is bad for applications using Jetpack Compose, because AppCompatActivity requires you to use a theme (AppCompatTheme) that is incompatible with the recommended Material theme in Compose apps.
This is an overly restrictive approach, for two reasons:
Finally, if after all this the PortalView is still in an invalid context, the code should check the cast and throw a proper exception with an informative error message, as opposed to a class cast exception.