ionic-team / ionic-portals-android

Other
4 stars 3 forks source link

feat: added constructor for PortalView that takes a Portal directly #51

Closed carlpoole closed 1 year ago

carlpoole commented 1 year ago

…instead of relying on the PortalManager to retrieve the Portal

Steven0351 commented 1 year ago
if (PortalManager.size() == 0) {
    throw Exception("Ionic Portals has not been setup with any Portals!")
}

Probably want to remove this check. Or at least only check when portal is null:

if (portal == null && PortalManager.size() == 0) {
    throw Exception("Ionic Portals has not been setup with any Portals!")
}