search

ionic-team / ionic-pwa-toolkit

Build lightning fast Progressive Web Apps with zero config and best practices built-in. Go from zero to production ready with Ionic and Stencil (Web Components).
MIT License
633 stars 74 forks source link

Failing unit tests in master #100

Closed cocowmn closed 5 years ago

cocowmn commented 5 years ago

Unit tests fail on new project startup

The method onSWUpdate does not exist on AppRoot https://github.com/ionic-team/ionic-pwa-toolkit/blob/bc93b6d3e164d0b3833dec3506bd887e18bf895f/src/components/app-root/app-root.spec.ts#L24

The property toastCtrl does not exist on AppRoot https://github.com/ionic-team/ionic-pwa-toolkit/blob/bc93b6d3e164d0b3833dec3506bd887e18bf895f/src/components/app-root/app-root.spec.ts#L17

It looks like this describe block needed to be removed with c1abb7cb042bb56a9035f61f3d5f4b0e530ac4ae.