search

ionic-team / ionic-pwa-toolkit

Build lightning fast Progressive Web Apps with zero config and best practices built-in. Go from zero to production ready with Ionic and Stencil (Web Components).
MIT License
635 stars 74 forks source link

Missing types for Ionic components #101

Closed Cammisuli closed 5 years ago

Cammisuli commented 5 years ago

With the latest release (@ionic/core@one and @stencil/core@one) typings seem to be broken for Ionic components.

Hovering over the JSX reveals no information. image

I managed to get around and fix this by extending the JSX interface in interfaces.d.ts like so:

import { JSX as JsxIonic } from '@ionic/core';

declare module '@stencil/core' {
  export namespace JSX {
    interface IntrinsicElements extends JsxIonic.IntrinsicElements {}
  }
}

With the above applied, type information appears for Ionic components: image

If this an acceptable solution to this, I'll be more than happy to create a PR and update the repo. If there's already something in progress that fixes this issue, then I'll be happy with that too.

Thanks!

arjunyel commented 5 years ago

Ionic and Stencil have been updated, should be fixed now, thank you for the report!