search

ionic-team / ionic-pwa-toolkit

Build lightning fast Progressive Web Apps with zero config and best practices built-in. Go from zero to production ready with Ionic and Stencil (Web Components).
MIT License
635 stars 74 forks source link

Cannot read icon file #27

Closed peterennis closed 6 years ago

peterennis commented 6 years ago

I'm submitting a ... (check one with "x") [x] bug report [ ] feature request [ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or https://stencil-worldwide.slack.com

Current behavior: https://raw.githubusercontent.com/ionic-team/ionic-pwa-toolkit/master/src/assets/icon/favicon.ico

Download and try to open with Icon Editor

capture242

Expected behavior: It should be an icon Windows 10, x64

What is the actual format? How do I create it when the file is not recognized in a Windows icon editor? Tested from clone and also direct download.

jgw96 commented 6 years ago

Hello! Thanks for opening an issue with us! As this seems like more of a support question I will urge that you ask this question on our slack channel. Thanks for using the Ionic PWA Toolkit!

peterennis commented 6 years ago

@jgw96

I did a support request with Axialis:

On Monday, March 26, 2018, 1:11:48 AM PDT, Axialis Team axteam08@axialis.com wrote: Hi Peter, Thanks for your message. We have fixed the 404 error message on the support page. Thanks for pointing this out.

The FAVICON.ICO file is not an ICO file format. It is in fact a PNG file renamed to ICO. That’s the reason why IconWorkshop can’t open it.

Best regards, Marc

So for correctness you should rename this file .PNG or create a proper .ICO