search

ionic-team / ionic-pwa-toolkit

Build lightning fast Progressive Web Apps with zero config and best practices built-in. Go from zero to production ready with Ionic and Stencil (Web Components).
MIT License
635 stars 74 forks source link

button attribute menuToggle prevents compilation #33

Closed cdock1029 closed 6 years ago

cdock1029 commented 6 years ago

Resources: Before submitting an issue, please consult our docs.

Stencil version: (run npm list @stencil/core from a terminal/cmd prompt and paste output below):

@stencil/core@0.6.1

I'm submitting a ... (check one with "x") [x] bug report [ ] feature request [ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or https://stencil-worldwide.slack.com

Current behavior: adding menuToggle attribute to a button produces typescript compilation error:

Property 'menuToggle' does not exist on type 'IonButtonAttributes'.

Expected behavior: Using ionic components as documented just works.

Steps to reproduce: Try to implement button component as described here: https://ionicframework.com/docs/api/components/toolbar/Navbar/

Related code:

<button ion-button icon-only menuToggle>
  <ion-icon name='menu'></ion-icon>
</button>

Other information: I'm new to Ionic. Is there documentation about using it with Stencil ?

arjunyel commented 6 years ago

Try npm i --save @ionic/core @stencil/core

cdock1029 commented 6 years ago

I kinda figured out that a lot of the library is in flux switching to stencil.

The main point here is that the docs I was referencing aren't applicable to the updated widgets.

A better reference than the current docs, for anyone else having issues:

https://github.com/ionic-team/ionic-stencil-conference-app Seems to be using updated API's.

Or just look through the ionic source.