search

ionic-team / ionic-pwa-toolkit

Build lightning fast Progressive Web Apps with zero config and best practices built-in. Go from zero to production ready with Ionic and Stencil (Web Components).
MIT License
635 stars 74 forks source link

Browser back button must be invoked twice before going back #39

Closed insightcoder closed 6 years ago

insightcoder commented 6 years ago

Stencil version: (run npm list @stencil/core from a terminal/cmd prompt and paste output below):

`-- @stencil/core@0.7.7

I'm submitting a ... (check one with "x") [x] bug report [ ] feature request [ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or https://stencil-worldwide.slack.com

Current behavior: When using the sample app, when I click on the profile page, the url appropriately changes to /profile/stencil. If I click on the ion-back-button, we are routed correctly back to /. However, if I click on the browser back button, nothing happens. If I click on the browser back button a second time, we are routed back to /.

Expected behavior: I expect a single browser back click to navigate back to root, rather than requiring two clicks.

Steps to reproduce: I think it is described enough in Current behavior. Let me know otherwise!

jgw96 commented 6 years ago

Hey! I just updated the toolkit to use the latest release of @ionic/core which has a fix for this issue. Thanks for opening an issue with us!

insightcoder commented 6 years ago

@jgw96 Excellent. Thanks! When developing with this toolkit, is it fine to just update the underlying npm dependencies to the latest, or are those carefully coordinated?