search

ionic-team / ionic-pwa-toolkit

Build lightning fast Progressive Web Apps with zero config and best practices built-in. Go from zero to production ready with Ionic and Stencil (Web Components).
MIT License
635 stars 74 forks source link

Remaining reference to ToastController breaks build with latest ionic/core #62

Closed codyburleson closed 6 years ago

codyburleson commented 6 years ago

Stencil version: (run npm list @stencil/core from a terminal/cmd prompt and paste output below):

@stencil/core@0.8.0

I'm submitting a ... (check one with "x") [X ] bug report

Current behavior:

After fresh setup, if you switch the version of ionic core in package.json to the latest like so:

 "dependencies": {
    "@ionic/core": "4.0.0-alpha.4",
    "@stencil/core": "0.8.0"
  },

You get a bad build with errors reporting no ToastController exported. There is a remaining reference to ToastController that needs to be changed to:

@Prop({ connect: 'ion-toast-controller' }) toastCtrl: HTMLIonToastControllerElement;

...which fixes the build.

It's either in my-app or app-profile; can't remember.

arjunyel commented 6 years ago

Fixed by https://github.com/ionic-team/ionic-pwa-toolkit/pull/60/files

jgw96 commented 6 years ago

Hello all, this has since been fixed. Thanks for using the Ionic PWA Toolkit!

numerized commented 4 years ago

hello here, this issue is back with a fresh git clone of this ionic-pwa-toolkit

HTMLIonToastControllerElement


           Cannot find name 'HTMLIonToastControllerElement'.

     L13:    @Prop({ connect: "ion-toast-controller" })
     L14:    toastCtrl: HTMLIonToastControllerElement;

[06:40.3]  build failed, watching for changes... in 1.34 s```