search

ionic-team / ionic-pwa-toolkit

Build lightning fast Progressive Web Apps with zero config and best practices built-in. Go from zero to production ready with Ionic and Stencil (Web Components).
MIT License
635 stars 74 forks source link

Make possible to change Application's Variables Color in a single file #64

Closed luispalacios270 closed 6 years ago

luispalacios270 commented 6 years ago

Resources: Already check the documentation and the feature is not ready yet.

Stencil version: @stencil/core@0.7.24

I'm submitting a ... (check one with "x") [ ] bug report [x] feature request [ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or https://stencil-worldwide.slack.com

Current behavior: Right now is not possible to change the THEME colors variable of the application as you can in IONIC because the variable are taken from a file in the Node_Module folder.

Expected behavior: Be able to change the applications colors as easily as you can in IONIC just changing a file as you can in IONIC in the theme.scss file.

Steps to reproduce: Create a new PWA Toolkit app

Other information: Even thought you can actually change the colors through component scss files and the global scss file it would be way more easier to mantain if you can change the application color in a file as you can do in IONIC, Since this affect pretty much every component built-in the PWA Toolkit.

jgw96 commented 6 years ago

Hello! I recently updated this to include https://github.com/ionic-team/ionic-pwa-toolkit/blob/master/src/global/app.css which allows you to change the theme from one file. Thanks!