ionic-team / ionic-pwa-toolkit

Build lightning fast Progressive Web Apps with zero config and best practices built-in. Go from zero to production ready with Ionic and Stencil (Web Components).
MIT License
635 stars 74 forks source link

Build broken with latest stencil - no exported member 'setupConfig' #66

Closed peterennis closed 6 years ago

peterennis commented 6 years ago

Stencil version: (run npm list @stencil/core from a terminal/cmd prompt and paste output below): "@ionic/core": "4.0.0-alpha.7", "@stencil/core": "0.9.1" "@stencil/sass": "0.0.5",

C:\ae\adaept.com\ionic-pwa-toolkit>ionic info
[WARN] You are not in an Ionic project directory. Project context may be missing.
cli packages: (C:\Users\peter\AppData\Roaming\npm\node_modules)

   @ionic/cli-utils  : 2.0.0-rc.6
   ionic (Ionic CLI) : 4.0.0-rc.6

System:

   NodeJS : v8.11.1
   npm    : 6.0.1
   OS     : Windows 10

I'm submitting a ... (check one with "x") [x] bug report [ ] feature request [ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or https://stencil-worldwide.slack.com

Current behavior: breaking

Expected behavior: working

Steps to reproduce:

C:\ae\adaept.com\ionic-pwa-toolkit>npm start

> @stencil/starter@0.0.1 start C:\ae\adaept.com\ionic-pwa-toolkit
> npm run dev

> @stencil/starter@0.0.1 dev C:\ae\adaept.com\ionic-pwa-toolkit
> sd concurrent "stencil build --dev --watch" "stencil-dev-server"

[38:47.8]  @stencil/core v0.9.1
[38:47.8]  build, app, dev mode, started ...
[38:47.9]  compile started ...
[38:51.7]  compile finished in 3.80 s

[ ERROR ]  typescript: C:/ae/adaept.com/ionic-pwa-toolkit/src/global/app.ts, line: 1
           Module '"C:/ae/adaept.com/ionic-pwa-toolkit/node_modules/@ionic/core/dist/types/index"' has no exported
           member 'setupConfig'.

      L1:  import { setupConfig } from '@ionic/core';

[38:52.1]  build failed, watching for changes... in 4.31 s

Other information:

peterennis commented 6 years ago

Fixed here: https://github.com/peterennis/aepwa

Using this PR: https://github.com/ionic-team/ionic-pwa-toolkit/pull/60/files

Closed in favor of this: https://github.com/ionic-team/ionic-pwa-toolkit/issues/67