search

ionic-team / ionic-site

Repo for the ionicframework.com site
https://ionicframework.com
Apache License 2.0
452 stars 3.25k forks source link

Build your first app Angular uses deprecated cameraPhoto object #1609

Closed ne6toto closed 1 year ago

ne6toto commented 3 years ago

Hi, I am new here, but I believe I found the following issue while working through the "Build your first app" excercise with Angular:

The "Saving Photos to the Filesystem" instructs the user to use the CameraPhoto object in private async savePicture(cameraPhoto: CameraPhoto) { } Looking through @capacitor's Camera definitions.d.ts file it seems that CameraPhoto is deprecated, and that Photo should be used instead. This would however result in a name conflict with the previous step, where the user declares an interface with the same name: export interface Photo { filepath: string; webviewPath: string; }

I would be happy to submit a pull request for this, but I was unable to find the code responsible for that webpage in this repository.

jcesarmobile commented 1 year ago

Thanks for the issue, it was fixed long ago. The proper repository for issues on the docs is https://github.com/ionic-team/ionic-docs/issues