search

ionic-team / ionic-unit-testing-example

Example of adding unit testing in your Ionic 2.x or greater apps with Karma and Jasmine
Other
374 stars 145 forks source link

Upgrade to ionic 3.1.1 #31

Closed lightheaded closed 7 years ago

lightheaded commented 7 years ago

When updating to ionic 3.1.1 in my project, I started receiving errors and tests were failing.

Uncaught TypeError: Cannot read property 'links' of null
  at webpack:///~/ionic-angular/util/module-loader.js:106:0 <- karma-test-shim.js:58492

There was another PR which also wants to upgrade to latest ionic, but it does a bit more than that and does not work for me. This one worked with a fresh npm install and yielded consistent passing of the tests. This was resolved by adding links to the IonicModule and update ionic app scripts to 1.3.7.

danielsogl commented 7 years ago

What is the difference between your and my PR?

lightheaded commented 7 years ago

As of your last commits, there's no difference. Your branch wasn't working when I created this PR. Closing now.