ionic-team / ionic-unit-testing-example

Example of adding unit testing in your Ionic 2.x or greater apps with Karma and Jasmine
Other
374 stars 145 forks source link

Pull Request: Updated Karma to Version 2 #87

Open leifwells opened 6 years ago

leifwells commented 6 years ago

This pull requests updates Karma to ^2.0.0 along with various related packages.

I may not have gone far enough with this update, but it unit tests and E2E tests are working.

I am looking for any feedback.

esilkensen commented 6 years ago

I have been using these versions without any issues, thanks!

ozoli commented 6 years ago

I needed to add --single-run to the end of the npm run test command to close the browser after the tests complete. OS Ubuntu 16.02 LTS Chrome

alex-steinberg commented 6 years ago

It is working great for me so far.

letsila commented 6 years ago

I works 👌🏽

TomBillingtonUK commented 5 years ago

We have just updated our project to use these values and everything seems to work. Would be great if this could be merged in