search

ionic-team / ionic-v1

The repo for Ionic 1.x. For the latest version of Ionic, please see https://github.com/ionic-team/ionic
Other
193 stars 187 forks source link

bug: ionic-floating-label #158

Open jgw96 opened 7 years ago

jgw96 commented 7 years ago

From @jbrownssf on March 20, 2016 4:3

Type: bug

Ionic Version: 1.x

Platform: all

I only testing on web and iOS 9. Adding item-floating-label through ngClass does not reveal the upper label correctly when text is input into the label. I looked at the elements in the project I am working on and saw this: First Name I noticed the aria-label="" had {{}} when i used ng-class, and it did not when I put the text in as a normal class. Here is my code pen that replicates the bug. http://codepen.io/jbrownssf/pen/QNpKMx?editors=1010

Copied from original issue: driftyco/ionic#5891

jgw96 commented 7 years ago

@jbrownssf Thanks for providing the codepen! I did some testing myself and there does seem to be a bug where the has-input class is not being applied that we will have to look into. Just a suggestion but im not sure that changing an input programmatically is gonna provide for the best user experience as it may be a little jarring and confusing for the user, but as i said that is totally a suggestion, and im definitely not a UX expert! haha (:

jgw96 commented 7 years ago

From @jbrownssf on March 21, 2016 22:38

Thanks for the tip, although I am working on making a tool that creates every possible ionic CSS element to make coding the UX easier for future apps. My temporary preview before the element gets added to the current state is where I want to dynamically change it.