search

ionic-team / ionic-v1

The repo for Ionic 1.x. For the latest version of Ionic, please see https://github.com/ionic-team/ionic
Other
193 stars 187 forks source link

fix(history): fixes Back Button issue (#122). Issue occurs when switc… #210

Closed ulesta closed 7 years ago

ulesta commented 7 years ago

…hing tabs and navigating to children views.

Short description of what this resolves:

This fixes a Back Button issue (#122) which occurs when a View's backViewId reference is removed during a View transition (usually happens on Tab switch). This is a result of setting backViewId to null whenever there is a circular cycle (which creates an infinite loop), i.e.: T1V1 -> T2V1 -> T2V2 -> T1V1. The iteration through Views, however, does not take into account Views in the same History stack. This could potentially remove backViewId from Views within the same History stack causing the Back Button to disappear when navigating to a child View.

Changes proposed in this pull request:

Ionic Version: 1.3.2 Fixes: #122

gabrielbazan7 commented 7 years ago

I just tested on https://github.com/bitpay/copay. I can confirm it works.

JDonadio commented 7 years ago

Any update about this? Copay it's looking forward to this fix 😉

mlynch commented 7 years ago

Nothing like a PR with tests, thanks so much! 🍻

JDonadio commented 7 years ago

@mlynch can you tell me when this fix will be on production?

gabrielbazan7 commented 7 years ago

I can't see this changes on the release folder. Thanks

ulesta commented 7 years ago

Hey @gabrielbazan7, since it's not part of the release yet, you'd have to build the release yourself via RELEASE=true gulp build and copy the files from dist to release. We have our own forked release branch if you want to use it: https://github.com/UltimateSoftware/ionic-v1/tree/release

Ideally, we still want to be pointing to the official repo, so let's wait on @mlynch to see what the ETA is for the next release

mlynch commented 7 years ago

Thanks @ulesta, was thinking of doing a release today, need to spend some time testing

ulesta commented 7 years ago

@mlynch awesome, thanks! Keep us posted! 💯

mlynch commented 7 years ago

Okay, code updated and the release directory updated with 1.3.3. Try cloning the repo and using the version in that directory.

Our CI isn't quite hooked up to v1 now that we moved it out of the core ionic repo, so it'll be a bit before it makes it to bower/etc.

ulesta commented 7 years ago

Thanks @mlynch ! Any chance we could publish the release to NPM or at least tag it as a release on Github? Let me know! Thanks again! 😄

ulesta commented 7 years ago

@mlynch any ETA on tagging this as a release so we can start updating our dependencies?

ajmesa9891 commented 7 years ago

@ulesta and @mlynch It would be great to get this tagged soon.

mastronaute commented 7 years ago

I could I benefit the fix? Can I update my Ionic version with NPM or should I build a release? If so, how could I do it?

mlynch commented 7 years ago

Hi all, please find the new release files here: https://github.com/driftyco/ionic-v1/tree/master/release

Unfortunately, we won't be able to get this tagged soon, our release system is in a state of flux and we don't have the automation working at the moment.

For now, this is a 100% legitimate way to get the releases. Going to lock this issue so others can see the note here. Thanks.