search

ionic-team / ionic-v1

The repo for Ionic 1.x. For the latest version of Ionic, please see https://github.com/ionic-team/ionic
Other
192 stars 187 forks source link

Rounded edges of the iPhone X on ionic #317

Closed kas84 closed 6 years ago

kas84 commented 6 years ago

Hi,

Are we going to have support for iPhone X UI on ionic V1?

captura de pantalla 2017-09-16 a las 20 39 17

I guess it also needs some kind of support from Cordova!

mlynch commented 6 years ago

@sbasi5576 that's due to WKWebView enforcing CORS (like a normal browser). To get around that, add localhost:8080 to your allowed origins on the server

stripathix commented 6 years ago

@josandretto I guess that will not handle landscape mode splash screen or will it?

mhartington commented 6 years ago

Orientation can be locked via the config.xml

http://cordova.apache.org/docs/en/latest/config_ref/index.html

josandretto commented 6 years ago

@stripathix, I would guess not since the splash screen probably shows up before app.js executes. You might be able to do that with cordova-plugin-splashscreen and then define the splash screen for landscape iPhone X in config.xml.

stripathix commented 6 years ago

@josandretto thanks for the help. Anyways now I am doing this by a shell script to manipulate .plist file.

cd platforms cd ios cd WeatherSpork.xcodeproj sed -i "" '/AdSupport.framework/d' project.pbxproj sed -i "" '/libAdIdAccess/d' project.pbxproj cd .. cd WeatherSpork sed -i "" '1,/UIInterfaceOrientationLandscapeLeft/{/UIInterfaceOrientationLandscapeLeft/d;}' WeatherSpork-Info.plist sed -i "" '1,/UIInterfaceOrientationLandscapeRight/{/UIInterfaceOrientationLandscapeRight/d;}' WeatherSpork-Info.plist

mhartington commented 6 years ago

Hey folk! Since the original issue posted here has been solved, I'm going to lock this issue. If you have questions regarding anything WKWebview related, please post them on the Forum! Thanks!