It seems that the body of ionic should remove the class modal-open, but if using !modalStack.length, it failes to do this when modalStack.length > 0. In my opinion, it should be fixed as followed:
if (modalStack.length > 0) {
// ...
}
In addition, if check modal stack whether it is empty when timeout function is fired, the stack will be cleared, resulting in wrong process. Therefore, we need to assign it to a variable outside.
Actually, I have found that modal-open class is not absolutely related to the modalStack, which means that we can not easily use the length of modalStack to judge whether we should remove the class name modal-open.
Short description of what this resolves:
It seems that the body of ionic should remove the class
modal-open, but if using!modalStack.length, it failes to do this whenmodalStack.length > 0. In my opinion, it should be fixed as followed:In addition, if check modal stack whether it is empty when timeout function is fired, the stack will be cleared, resulting in wrong process. Therefore, we need to assign it to a variable outside.Actually, I have found that
modal-openclass is not absolutely related to the modalStack, which means that we can not easily use the length of modalStack to judge whether we should remove the class namemodal-open.Changes proposed in this pull request:
Ionic Version: 1.3.2 Fixes: #