search

ionic-team / ionic-v1

The repo for Ionic 1.x. For the latest version of Ionic, please see https://github.com/ionic-team/ionic
Other
192 stars 187 forks source link

Missing closing brackets in _platform.scss #328

Open jackvial opened 6 years ago

jackvial commented 6 years ago

Short description of the problem:

Missing closing brackets here https://github.com/ionic-team/ionic-v1/blob/master/scss/_platform.scss#L80-L81

What behavior are you expecting?

Correct syntax

Steps to reproduce:

  1. Go to lines 80-81 in /scss/_platform.scss
  2. Notice the closing brackets of the css calc function are missing
    .has-header.has-subheader.has-tabs-top {
      top: $bar-height + $bar-subheader-height + $tabs-height + $ios-statusbar-height;

      top: calc(#{$bar-height + $bar-subheader-height + $tabs-height} + constant(safe-area-inset-right);
      top: calc(#{$bar-height + $bar-subheader-height + $tabs-height} + env(safe-area-inset-right);
    }

Which Ionic Version? 1.x or 2.x 1.3.4