search

ionic-team / ionic-v1

The repo for Ionic 1.x. For the latest version of Ionic, please see https://github.com/ionic-team/ionic
Other
193 stars 187 forks source link

v1 auto installs older version of cordova-plugin-splashscreen #404

Open rolinger opened 5 years ago

rolinger commented 5 years ago

When starting a new v1 app, Ionic v1 is adding cordova-plugin-splashscreen (v4.0.3), however, that plugin is now updated to 5.0.3 which brings fixes for specific iOS and Android splashscreen issues.

Please update the build to include the latest release of splashscreen.

c:\Users\RPO\dev\myApp>ionic platform add android ? (node:8328) fs: re-evaluating native module sources is not supported. If you are using the graceful-fs module, please update it to a more recent version. Updated the hooks directory to have execute permissions Using cordova-fetch for cordova-android@^8.0.0 Adding android project... Creating Cordova project for the Android platform: Path: platforms\android Package: com.whipstermobile Name: WHIPSTER Activity: MainActivity Android target: android-28 Subproject Path: CordovaLib Subproject Path: app Android project created with cordova-android@8.0.0 Installing "cordova-plugin-console" for android Installing "cordova-plugin-device" for android Installing "cordova-plugin-splashscreen" for android Installing "cordova-plugin-statusbar" for android Installing "cordova-plugin-whitelist" for android

This plugin is only applicable for versions of cordova-android greater than 4.0. If you have a previous platform version, you do not need this plugin since the whitelist will be built in.

Installing "ionic-plugin-keyboard" for android Running command: node c:\Users\RPO\dev\myApp\hooks\after_prepare\010_add_platform_class.js c:\Users\RPO\dev\myApp Saving platform to package.json file

c:\Users\RPO\dev\myApp>cordova plugin cordova-plugin-console 1.1.0 "Console" cordova-plugin-device 1.1.4 "Device" cordova-plugin-splashscreen 4.0.3 "Splashscreen" cordova-plugin-statusbar 2.2.1 "StatusBar" cordova-plugin-whitelist 1.3.1 "Whitelist" ionic-plugin-keyboard 2.2.1 "Keyboard"

c:\Users\RPO\dev\myApp>cordova plugin remove cordova-plugin-splashscreen Uninstalling cordova-plugin-splashscreen from android Removing "cordova-plugin-splashscreen" Removing plugin cordova-plugin-splashscreen from config.xml file... Removing cordova-plugin-splashscreen from package.json

c:\Users\RPO\dev\myApp>cordova plugin add cordova-plugin-splashscreen Installing "cordova-plugin-splashscreen" for android Adding cordova-plugin-splashscreen to package.json

c:\Users\RPO\dev\myApp>cordova plugin cordova-plugin-console 1.1.0 "Console" cordova-plugin-device 1.1.4 "Device" cordova-plugin-splashscreen 5.0.3 "Splashscreen" cordova-plugin-statusbar 2.2.1 "StatusBar" cordova-plugin-whitelist 1.3.1 "Whitelist" ionic-plugin-keyboard 2.2.1 "Keyboard"

rolinger commented 5 years ago

splashscreen 5.0.3 fixes iOS issues with splash screen images. Not certain if there are any real fixes for Android environment as I never had any issues with 4.0.3. Regardless, after a new project build:

cordova plugin remove cordova-plugin-splashscreen

Then

cordova plugin add cordova-plugin-splashscreen