search

ionic-team / ionic-v3

The repo for Ionic 3.x. For the latest version of Ionic, please see https://github.com/ionic-team/ionic
Other
129 stars 86 forks source link

bug: Ionic-segments are announced as toggle button in Talkback #1114

Open mastergogo opened 3 years ago

mastergogo commented 3 years ago

We are using Ionic-segments and Ionic-segment-button, and on tap of these buttons we are switching between the view (via CSS), what is happening when we run a TalkBack screen reader, Talkback announces it (ion-segment-button)as a toggle button because under this component aria-pressed=false/true attribute is given. however, it is not a toggle button and talkback user might assume it as toggle i.e. on/off, here is a repo that produces the same results when checked with talkback, let me know if more info is needed.

liamdebeasi commented 3 years ago

Thanks for the issue. What device are you testing this on?

mastergogo commented 3 years ago

Hi @liamdebeasi, I'm testing this on Samsung Galaxy M30 with android 10.

liamdebeasi commented 3 years ago

Thanks for the follow up. The application you provided is using Ionic Framework v3. This repo is dedicated to issues pertaining to Ionic Framework v4+, so I am going to move this to the ionic-v3 repo.

mastergogo commented 3 years ago

Hi @liamdebeasi we are using Ionic v5, 5.0.7 precisely - and it is appearing there too.

liamdebeasi commented 3 years ago

Can you provide a code reproduction using the latest version of Ionic Framework?

mastergogo commented 3 years ago

Hi, @liamdebeasi I have added one repo here under the file: Ionic-talkback-issue/src/app/recipes/recipe-detail/recipe-detail.page.html you can find the ion-segment component used at the bottom if you run a talkback screen reader on this page, ion-segment will be announced as toggle button. let me know if this will help.