search

ionic-team / ionic-v3

The repo for Ionic 3.x. For the latest version of Ionic, please see https://github.com/ionic-team/ionic
Other
128 stars 85 forks source link

ion-slides with dir="rtl" misbehaves when lockSwipeToNext is called #115

Open RafaelKr opened 7 years ago

RafaelKr commented 7 years ago

Ionic version: (check one with "x") [ ] 1.x (For Ionic 1.x issues, please use https://github.com/ionic-team/ionic-v1) [ ] 2.x [x] 3.x

I'm submitting a ... (check one with "x") [x] bug report [ ] feature request [ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or http://ionicworldwide.herokuapp.com/

Current behavior: RTL: http://plnkr.co/edit/Fg8xB3ThH36Dd0ReFdj9?p=preview

Expected behavior: LTR: http://plnkr.co/edit/gro4Bmvx2uBo02fqgEVM?p=preview

Steps to reproduce: When you swipe to the last slide (checked by slider.isEnd()), then you shouldn't be able to swipe further. This is accomplished by calling slider.lockSwipeToNext(true). This is working as expected in the left-to-right version. But when you set <ion-slides dir="rtl"> and slider.lockSwipeToNext(true) is called, the slider behaves like freeMode is set to true until you swipe back to the first slide.

Additional info: I also checked this with ionic-angular@3.5.2

jgw96 commented 7 years ago

@AmitMY would you be able to take a look at this one?

AmitMY commented 7 years ago

dir="rtl" is extremely buggy on slides, that is why I suggested to add a reverse input, and it was kind of approved but did not make it before the great code freeze on master.. https://github.com/ionic-team/ionic/pull/12026

I believe that that PR might also fix this issue for the dir="rtl", and will take another look as soon as the team start to merge PRs again (because it will probably need refactoring once mono is merged or v4 stuff)

tomavic commented 6 years ago

Is there any update on this?

RafaelKr commented 6 years ago

Have a look on #12026

ionitron-bot[bot] commented 5 years ago

Thanks for the issue! We have moved the source code and issues for Ionic 3 into a separate repository. I am moving this issue to the repository for Ionic 3. Please track this issue over there.

Thank you for using Ionic!

ansarikhurshid786 commented 5 years ago

I am also facing same issue. is there any workaround ?