fix(icon): icon names with numbers are correctly converted to kebab case

ionic-team / ionicons

Premium hand-crafted icons built by Ionic, for Ionic apps and web apps everywhere 🌎

http://ionicons.com

MIT License

17.39k stars 2.06k forks source link

Closed MasonVX closed 2 months ago

MasonVX commented 2 months ago

resolves #1338

Do not contribute very often publicly, so any feedback regarding the pull request is welcome.

I know I jumped the gun by providing a pull request before the bug report has been validated.

I extended the existing test to cover the case with numbers. I keept the old test in place to avoid regression.

Unfortunately I can not link this pull request to my bug report: https://github.com/ionic-team/ionicons/issues/1338

liamdebeasi commented 2 months ago

Merged. Thank you!