ionic-team / ionicons

Premium hand-crafted icons built by Ionic, for Ionic apps and web apps everywhere 🌎
http://ionicons.com
MIT License
17.39k stars 2.06k forks source link

bug: "person-circle-outline" is not affected by "--ionicon-stroke-width" #1357

Closed ozgurg closed 1 month ago

ozgurg commented 1 month ago

Current Behavior

When I set a custom stroke value for ion-icon with --ionicon-stroke-width, as the docs say, it works for icons that I test, but person-circle-outline is not affected by it.

Expected Behavior

person-circle-outline should change its stroke width like other icons.

Steps to Reproduce

1) Add this HTML:

<ion-icon name="person-circle-outline"></ion-icon>
<ion-icon name="home-outline"></ion-icon>
<ion-icon name="chatbubbles-outline"></ion-icon>
<ion-icon name="notifications-outline"></ion-icon>

2) Add this CSS:

ion-icon {
   --ionicon-stroke-width: 16px
}

3) You should see the stroke width differences between these icons.

2024-03-28_14-10

Code Reproduction URL

https://codepen.io/ozgurg/pen/RwOZOzE

Additional Information

No response

liamdebeasi commented 1 month ago

Thanks for the report. It looks like the path elements for the person-circle-outline icon are not getting the .ionicon-stroke-width class. As a result, --ionicon-stroke-width does not apply.

liamdebeasi commented 1 month ago

Apologies, it looks like this is the same issue as https://github.com/ionic-team/ionicons/issues/923, so I am going to merge the two.