search

ionic-team / ionicons

Premium hand-crafted icons built by Ionic, for Ionic apps and web apps everywhere 🌎
http://ionicons.com
MIT License
17.4k stars 2.06k forks source link

Fix logo icon type snippets #544

Closed ghybs closed 2 months ago

ghybs commented 6 years ago

Hi,

This PR tweaks the icon name if it is a logo type for code snippets in ToastBar and UsagePage's Content. However, in UsagePage it defaults to "heart" value for "Platform specific icons" section, because it does not apply to logo type icons (you cannot use ios and md attributes with a logo value, and you cannot specify "ios-logo-github" or "md-logo-github" to the name attribute).

A minor inconsistency remains in the ToastBar: the left title still displays the icon name, which does not include the logo- prefix. Since this title is very big, and for other icon types it is equal to the value you can pass to the name attribute, this might still create confusion when developer realizes it is not the case for logo type icons. But at least with this PR code snippets are now correct.

Fix #540

liamdebeasi commented 2 months ago

Thanks for the PR and apologies for the delay. According to the linked issue it looks like the original problem was resolved. I am going to close this, but let me know if you have any questions.