search

ionic-team / legacy-ionic-cloud

JavaScript Client for legacy Ionic Cloud services. See Ionic Pro for our new take on the ionic development lifecycle
Apache License 2.0
65 stars 26 forks source link

Ionic Native 3.x #199

Open vknabel opened 7 years ago

vknabel commented 7 years ago

Hi. We want to use Ionic Native 3.x, which is currently not possible with @ionic/cloud@0.16.0.

As #190 has been opened a while ago, I wanted to help with this. As all native plugins have to be instantiated (ideally through injection), I added them to the DIContainer class.

When trying npm run build it failed on master.

vknabel commented 7 years ago

How shall I resolve the merge conflicts? Shall I retain window.plugins.googleplus.logout etc. or shall I rely on this.googlePlus.logout?

janpio commented 7 years ago

Without understanding anything else what you did here: window.plugins.googleplus.logout would be using the Cordova plugin directly, this.googlePlus.logout would mean communicating with it via the Ionic Native plugin, correct? If so, the second one should be preferred.

vknabel commented 7 years ago

@piotrowski Yes I know. I just don't know wether those changes were just a temporary and hacky workaround or wether they were meant to stay.