ionic-team / native-run

Utility for running native binaries on iOS and Android devices and simulators/emulators
MIT License
120 stars 21 forks source link

refactor: remove invalid xcode check #353

Closed jcesarmobile closed 7 months ago

jcesarmobile commented 7 months ago

If the Xcode version is major.minor.patch, the Number(xcodeVersion) is returning NaN, so the < 10 check is always false. I could fix the version check, but since Xcode 10 is ancient, I think it's better to just remove the code as it's not doing anything.

Ionitron commented 7 months ago

:tada: This PR is included in version 2.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: