search

ionic-team / ng-cordova

OBSOLETE: Please move to Ionic Native https://github.com/ionic-team/ionic-native
https://github.com/ionic-team/ionic-native
MIT License
3.48k stars 1.06k forks source link

$cordovaAdMob implementation would be great! #360

Open EdL opened 9 years ago

EdL commented 9 years ago

I can see that it is listed in the ngCordova docs, and there has been some code added for it in the repo. However, the plugin and link in the ngCordova docs are for floatinghotpot/cordova-admob-pro but the code that has been added in the repo here looks like it is for his older plugin floatinghotpot/cordova-plugin-admob. It would be great if the ngCordova wrapper could be updated for the newer cordova-admob-pro and corresponding docs/examples added.

Many thanks

pbernasconi commented 9 years ago

You're right in saying that ngCordova should use the admob-pro plugin, will be added and corrected soon.

ladas-larry commented 9 years ago

For now you can find it here https://github.com/Dharmoslap/ng-cordova, I will prepare a Pull Request very soon.

ghost commented 9 years ago

Did you made your pull request?

ladas-larry commented 9 years ago

It is already there http://ngcordova.com/docs/plugins/adMob/.

EdL commented 9 years ago

Hi @Dharmoslap, @pbernasconi, I was just wondering if there are still plan to update the ngCordova plugin to use the floatinghotpot admob-pro version?

Thanks

pmn4 commented 9 years ago

to use the plugin com.google.cordova.admob you want $cordovaGoogleAds on the otherhand, to use com.rjfun.cordova.plugin.admob you want $cordovaAdMob.

Here is a PR to update the docs

EdL commented 9 years ago

Hi @pmn4 Thanks for pointing this out - I hadn't spotted the $cordovaGoogleAds code and it's been there for the past few months! Thanks for updating the docs. Hopefully it will clarify things for others!

jdnichollsc commented 7 years ago

+1 for update the documentation please!

jdnichollsc commented 7 years ago

window.plugins is deprecated...