ionic-team / ng-cordova

OBSOLETE: Please move to Ionic Native https://github.com/ionic-team/ionic-native
https://github.com/ionic-team/ionic-native
MIT License
3.48k stars 1.05k forks source link

Custom build not working well #454

Open matiastucci opened 9 years ago

matiastucci commented 9 years ago

I have included the custom build and it throws me an error. But, when I include the whole ng-cordova library, it works. I found that the difference is that in the custom build is saying:

angular.module('ngCordova.plugins', [
   'geolocation'
]);

when in the full file:

angular.module('ngCordova.plugins', [
   'ngCordova.plugins.geolocation'
]);
cfjedimaster commented 9 years ago

This hit me too. :\

pbernasconi commented 9 years ago

Closing this issue and moving it to #348. I'll try to get this fixed soon.

iver56 commented 9 years ago

I just experienced this issue.

My custom build had code like this:

angular.module('ngCordova.plugins', [
     'facebook',
     'geolocation',
     'keyboard',
     'socialSharing'
]);

That didn't work. It threw errors. The custom build worked only after I changed that code to the following:

angular.module('ngCordova.plugins', [
     'ngCordova.plugins.facebook',
     'ngCordova.plugins.geolocation',
     'ngCordova.plugins.keyboard',
     'ngCordova.plugins.socialSharing'
]);

@pbernasconi As far as I know, this issue still persists, although you closed it. https://github.com/driftyco/ng-cordova/issues/348 is about a missing s in some lines and is a different issue.

0reo commented 9 years ago

I got hit by a double whammy, this is what was generated for me just today

angular.module('ngCordova.plugins', [
     'appRate',
     'googleAnalytic'
]);

had to add in the ngCordova.plugins AND an s to google analytics to get it working

angular.module('ngCordova.plugins', [
     'ngCordova.plugins.appRate',
     'ngCordova.plugins.googleAnalytics'
]);
iver56 commented 9 years ago

@gortok This hasn't been solved yet. Could you please reopen this issue?

matiastucci commented 9 years ago

I just made a custom build and this is still happening. I fixed it adding ngCordova.plugins to my plugin