ionic-team / starters

Starter templates for Ionic apps, used by the Ionic CLI
MIT License
460 stars 316 forks source link

chore: deploy should run when tests pass #1812

Closed liamdebeasi closed 1 year ago

liamdebeasi commented 1 year ago

Deployment currently happens when all the tests are run. However, I failed to update the deploy step to only run once the tests are verified to all have passed (the "verify-test" and "verify-test-legacy") steps.

The current behavior shouldn't be causing issues, since tests must pass before PRs are merged anyways, but we should still wait for the verification step before deploying.