ionic-team / starters

Starter templates for Ionic apps, used by the Ionic CLI
MIT License
460 stars 316 forks source link

fix(angular): variables gets loaded after global #1834

Closed liamdebeasi closed 8 months ago

liamdebeasi commented 9 months ago

One of the issues I'm seeing devs run into with the Ionic 8 beta is with trying to override the default light theme. Devs are placing their overrides in theme/variables.scss. However, our angular.json config has it so that theme/variables.scss is loaded before global.scss (where the default light theme is imported).

Since both sets of styles target the same selector, they have the same specificity and the latest style to get added to the DOM wins (global.scss in this case). As a result, the custom styles do not apply.

This PR switches the order so global.scss is loaded first. This is really only needed for Ionic 8, so I could target the feature-8.0 branch. However, I figured it would be good to get this change out sooner since devs testing the Ionic 8 beta may create fresh apps.