build: bump stencil core and replace dist-custom-elements-bundle - Githubissues

ionic-team / stencil-component-starter

Minimal starter project for building shareable web components with Stencil

https://github.com/ionic-team/stencil

MIT License

278 stars 128 forks source link

build: bump stencil core and replace dist-custom-elements-bundle #107

Closed peterpeterparker closed 2 years ago

peterpeterparker commented 2 years ago

Hi,

This PR does the following:

bump Stencil core to v2.11.0 (current last version)
replace deprecated dist-custom-elements-bundle (reference RFC: Deprecating dist-custom-elements-bundle) with dist-custom-elements and update package.json (module and types) entries accordingly

P.S.: Console outputs of npm run build after replacing the custom bundle and before modifying the entries in package.json for reference purpose:
[ ERROR ] Package Json: package.json:9:3 package.json "types" property is set to "dist/custom-elements/index.d.ts" but cannot be found. It's recommended to set the "types" property to: ./dist/types/components.d.ts

L8: "es2017": "dist/esm/index.mjs", L9: "types": "dist/custom-elements/index.d.ts", L10: "collection": "dist/collection/collection-manifest.json",

[ WARN ] Package Json: package.json:6:3 package.json "module" property is set to "dist/custom-elements/index.js". It's recommended to set the "module" property to: ./dist/index.js
```
  L5:  "main": "dist/index.cjs.js",
  L6:  "module": "dist/custom-elements/index.js",
  L7:  "es2015": "dist/esm/index.mjs",
```

peterpeterparker commented 2 years ago

Coolio thx