search

ionic-team / stencil-component-starter

Minimal starter project for building shareable web components with Stencil
https://github.com/ionic-team/stencil
MIT License
278 stars 128 forks source link

fix(package): "type" points to wrong file #111

Closed George-Payne closed 2 years ago

George-Payne commented 2 years ago

"types" should point to the index of the types directory, to allow imports of utils exported from index.ts

George-Payne commented 2 years ago

There is a reproduction example here: https://github.com/George-Payne/extTransformsPlugin-bug-reproduction/commit/2d85c5344166be5b341b048ba5baf94d526caefa

If you switch the "types" back to components.d.ts (as it is in the starter) you can see that typescript fails on the import.

vaibhavshn commented 2 years ago

I was coming over to make this same PR. Thanks!