search

ionic-team / stencil-component-starter

Minimal starter project for building shareable web components with Stencil
https://github.com/ionic-team/stencil
MIT License
278 stars 128 forks source link

chore(deps): unpin puppeteer #129

Closed rwaskiewicz closed 7 months ago

rwaskiewicz commented 7 months ago

Changes

in 5fba47d017f5c3678d85d73da9e66b7ab0b9049c (#124), we pinned the project's dependency on puppeteer due to failing stencil ci steps when we ran the component-starter smoke tests. this issue wasn't strictly related to ci - end users would have seen this as well (ci was an early alert for us).

since then, the typing issue here appears to have cleared itself up. unpin the dependency and update the version of puppeteer.

by applying this patch, users will:

  1. get the latest version of puppeteer regardless of when they run npm init stencil@latest component
  2. no longer see a warning in their console that their version of puppeteer is no longer supported

Testing

I ran through effectively what we do today in the Stencil component starter smoke tests in Stencil's CI pipeline - build and test the project. Tested with Node 16 + 20 (it shouldn't make a difference since this is a TypeScript error, but better safe than sorry).

Formally, check out this branch and run npm install && npm run build && npm t -- --no-build.

Everything should pass, and you should not see the following warning folks see today on npm i:

npm i
npm WARN deprecated puppeteer@21.1.1: < 21.5.0 is no longer supported

added 2 packages, removed 2 packages, changed 8 packages, and audited 362 packages in 3s

38 packages are looking for funding
  run `npm fund` for details

found 0 vulnerabilities