search

ionic-team / stencil-component-starter

Minimal starter project for building shareable web components with Stencil
https://github.com/ionic-team/stencil
MIT License
278 stars 128 forks source link

Add components.d.ts to .gitignore #58

Closed reda-alaoui closed 5 years ago

reda-alaoui commented 6 years ago

Since components.d.ts is generated, I think it should be ignored by git.

CookieCookson commented 6 years ago

I agree with this! Was about to come here and create the same PR - it causes all sorts of merge conflicts when working across multiple branches.

CookieCookson commented 6 years ago

I've encountered a potential issue with this - if you try and do a generateDistribution: true build from a fresh clone, it complains that dist/types/components.d.ts is not present and fails. It works fine if you perform a generateWWW: true build first and THEN do this afterwards.