ionic-team / stencil-component-starter

Minimal starter project for building shareable web components with Stencil
https://github.com/ionic-team/stencil
MIT License
278 stars 129 forks source link

Correct the types file. #80

Closed marchbox closed 4 years ago

marchbox commented 5 years ago

Leaving it as index.d.ts causes stencil.core.d.ts not being generated with a fresh stencil build (run stencil build again will generate stencil.core.d.ts file though), because it's checking if index.d.ts file exists, but it really should be checking if components.d.ts file exists.

StefanNieuwenhuis commented 5 years ago

Will fix #81

marchbox commented 5 years ago

Friendly ping to see if this one needs more changes. Thanks!

gtranter commented 5 years ago

My experience is that stencil.core.d.ts gets built sometimes. It is not a "fresh build" problem. See https://github.com/ionic-team/stencil/issues/1705#issuecomment-528923433.