Please check if your PR fulfills the following requirements:
[x] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been reviewed and added / updated if needed (for bug fixes / features)
[x] Build (npm run build) was run locally for affected output targets
[x] Tests (npm test) were run locally and passed
[x] Prettier (npm run prettier) was run locally and passed
Pull request type
Please check the type of change your PR introduces:
[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):
What is the current behavior?
Issue URL: resolves #397
What is the new behavior?
defineProperty is now configurable meaning the properties can be changed. In this case, the actual property implementations do not change, but they are re-written when calling proxyInputs multiple times.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build) was run locally for affected output targetsnpm test) were run locally and passednpm run prettier) was run locally and passedPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue URL: resolves #397
What is the new behavior?
definePropertyis now configurable meaning the properties can be changed. In this case, the actual property implementations do not change, but they are re-written when callingproxyInputsmultiple times.Does this introduce a breaking change?
Other information
Dev build:
0.0.1-dev.11698340434.1c94d384Ionic dev build available here: https://github.com/ionic-team/ionic-framework/issues/28418#issuecomment-1781540392 I used this to manually verify that fix worked in Framework's reproduction case.
This PR uses the output target dev build, so we can leverage Ionic's e2e angular suite to help de-risk this fix: https://github.com/ionic-team/ionic-framework/pull/28423