Closed sean-perkins closed 9 months ago
Please check if your PR fulfills the following requirements:
npm run build
npm test
npm run prettier
Please check the type of change your PR introduces:
When adding a custom event with an inline type:
@Event() ionSwipe!: EventEmitter<{ side: Side }>;
The generated event type is invalid:
ionSwipe: EventEmitter<CustomEvent<IIonItemOptions{ side: IIonItemOptionsSide }>>;
There are two issues:
IIonItemOptions
Expected output is:
ionSwipe: EventEmitter<CustomEvent<{ side: IIonItemOptionsSide }>>;
Issue URL: N/A
Dev-build: 0.0.1-dev.11705624885.1949250b
0.0.1-dev.11705624885.1949250b
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build
) was run locally for affected output targetsnpm test
) were run locally and passednpm run prettier
) was run locally and passedPull request type
Please check the type of change your PR introduces:
What is the current behavior?
When adding a custom event with an inline type:
The generated event type is invalid:
There are two issues:
IIonItemOptions
.Expected output is:
Issue URL: N/A
What is the new behavior?
Does this introduce a breaking change?
Other information
Dev-build:
0.0.1-dev.11705624885.1949250b