chore(infra): migrate to pnpm

sean-perkins commented 5 months ago

Pull request checklist

Please check if your PR fulfills the following requirements:

[x] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been reviewed and added / updated if needed (for bug fixes / features)
[x] Build (npm run build) was run locally for affected output targets
[x] Tests (npm test) were run locally and passed
[x] Prettier (npm run prettier) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[x] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

What is the current behavior?

With the dependency on @lit/react that adds a peer dependency for @types/react, the workspace has a type resolution issue when trying to reconcile the version of @types/react in the example react project.

What is the new behavior?

Infrastructure

Migrates from npm to pnpm
Dev-build process is updated to use pnpm: https://github.com/ionic-team/stencil-ds-output-targets/actions/runs/8804393746/job/24164674258
Production release process is updated to use pnpm

Angular Output Target

Updated project dependencies
Updated test infrastructure to run locally with updated dependencies

Vue Output Target

Updated project dependencies

Does this introduce a breaking change?

[ ] Yes
[x] No

Other information

This PR is required to unblock https://github.com/ionic-team/stencil-ds-output-targets/pull/432.

rwaskiewicz commented 4 months ago

Taking a look now 👀

christian-bromann commented 4 months ago

It seems like we mostly have consensus to move forward with this. There are 3 remaining comments that we might want to address:

using --frozen-lockfile for the validate command, see https://github.com/ionic-team/stencil-ds-output-targets/pull/428#discussion_r1589143350
importing json files via assert, see (https://github.com/ionic-team/stencil-ds-output-targets/pull/428#discussion_r1591095983)
PNPM Volta support , see https://github.com/ionic-team/stencil-ds-output-targets/pull/428#discussion_r1589132838

I don't have any strong preferences for the first two issues. In regards to the Volta comment I suggest to merge @rwaskiewicz suggestion noting that Volta support for PNPM is experimental and if you don't use it, be advised to have the right Node.js version installed.

Thoughts @rwaskiewicz @sean-perkins ?

rwaskiewicz commented 4 months ago

Agreed with respect to Volta support - although we'll have to revisit our usage of https://github.com/actions/setup-node/blob/main/docs/advanced-usage.md#node-version-file in GH Actions if we remove it

ionic-team / stencil-ds-output-targets