The value accessor directives also need to be declared in the module file. This is achieved here by adding them to the directives array file, since it is assumed that the module declares and exports all elements of this array.
Pull request checklist
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been reviewed and added / updated if needed (for bug fixes / features)
[x] Build (npm run build) was run locally for affected output targets
[x] Tests (npm test) were run locally and passed
[x] Prettier (npm run prettier) was run locally and passed
Pull request type
Please check the type of change your PR introduces:
[ ] Bugfix
[X] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):
What is the current behavior?
The value accessor directives have to be added to the angular module manually.
The value accessor directives also need to be declared in the module file. This is achieved here by adding them to the directives array file, since it is assumed that the module declares and exports all elements of this array.
Pull request checklist
npm run build) was run locally for affected output targetsnpm test) were run locally and passednpm run prettier) was run locally and passedPull request type
Please check the type of change your PR introduces:
What is the current behavior?
The value accessor directives have to be added to the angular module manually.
Issue URL: https://github.com/ionic-team/stencil-ds-output-targets/issues/436
What is the new behavior?
The value acessor directives are included in the directivesArrayFile and thereby declared and exported by a module file as described in the angular integration guide (https://stenciljs.com/docs/angular#adding-the-angular-output-target)
Does this introduce a breaking change?
The value accessors need to be removed from the public-api exports, since they are not copied any more. The only export necessary hereafter is
This line should added to the angular integration guide (https://stenciljs.com/docs/angular#adding-the-angular-output-target)