Open danielleroux opened 3 weeks ago
Thanks for the issue!
This project is currently maintained for the purposes of supporting Ionic Framework. At this time, only new issues & pull requests that support Ionic Framework will be prioritized. For the latest updates regarding the maintenance status of this project, please see this section of the project's README
Prerequisites
Stencil Version
4.18.0
Stencil Framework Output Target
React
Stencil Framework Output Target Version
0.5.3
Current Behavior
includeImportCustomElements: true
removes the hydration class from the web component. This cause an issue regarding applying and removing classes from elements.Demo:
If you start toggle the value state you will see that after a cycle the
is-red
class should be removed again from the element but this does not happen due this check:https://github.com/ionic-team/stencil-ds-output-targets/blob/0eb22ba25fa808a4c71f25001e2640ac7a941405/packages/react-output-target/react-component-lib/utils/attachProps.ts#L8-L10
This issue is only happing with the following stencil.config:
(used in ionic)
Expected Behavior
ClassName check should not ignore a new empty className
Steps to Reproduce
Code Reproduction URL
https://github.com/danielleroux/className-Issue
Additional Information
No response