fix(react): ssr hydration with children - Githubissues

ionic-team / stencil-ds-output-targets

These are output targets that can be added to Stencil for React and Angular.

https://stenciljs.com

MIT License

250 stars 118 forks source link

fix(react): ssr hydration with children #464

Closed christian-bromann closed 2 months ago

christian-bromann commented 3 months ago

Pull request checklist

Please check if your PR fulfills the following requirements:

[x] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been reviewed and added / updated if needed (for bug fixes / features)
[ ] Build (npm run build) was run locally for affected output targets
[x] Tests (npm test) were run locally and passed
[x] Prettier (npm run prettier) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

What is the current behavior?

It seems I made a mistake when rebasing my previous nextjs dev branch and missed what I implemented in #447.

What is the new behavior?

Reapply what's in that PR + adding additional tests.

Does this introduce a breaking change?

[ ] Yes
[x] No

Other information