ionic-team / stencil-ds-output-targets

These are output targets that can be added to Stencil for React and Angular.
https://stenciljs.com
MIT License
250 stars 118 forks source link

bug: @ionic/react@8.2.8 -> IonRadio now rendered without the "value" prop #476

Closed mrsamse closed 2 months ago

mrsamse commented 2 months ago

Prerequisites

Ionic Framework Version

v8.x

Current Behavior

I upgraded my project today from @ionic/react v8.2.7 to v8.3.0 and noticed that the IonRadio now gets rendered without the "value" prop. This behaviour was introduced with the version 8.2.8:

Version 8.2.7 behaviour: React code:

<IonRadio value="de"><label>Test</label></IonRadio>

HTML Output:

<ion-radio value="de" class="md radio-checked radio-justify-space-between radio-alignment-center radio-label-placement-start ion-activatable ion-focusable" role="radio" aria-checked="true" tabindex="0"><label>Test</label></ion-radio>

Version 8.2.8 behaviour: React code:

<IonRadio value="de"><label>Test</label></IonRadio>

HTML Output:

<ion-radio class="md radio-checked radio-justify-space-between radio-alignment-center radio-label-placement-start ion-activatable ion-focusable" role="radio" aria-checked="true" tabindex="0"><label>Test</label></ion-radio>

Expected Behavior

Not sure if this was intentional but for us this is not a minor change but a breaking change, which should be declared in the release overview.

If this was unintentional this should be reverted.

Steps to Reproduce

Already described above

Code Reproduction URL

No link proved as everything is stated in the description

Ionic Info

Ionic:

Ionic CLI : 7.2.0 (/usr/local/lib/node_modules/@ionic/cli) Ionic Framework : @ionic/react 8.2.8

Capacitor:

Capacitor CLI : 6.1.2 @capacitor/android : 6.1.2 @capacitor/core : 6.1.2 @capacitor/ios : 6.1.2

Utility:

cordova-res : not installed globally native-run : 2.0.1

System:

NodeJS : v21.7.3 (/usr/local/Cellar/node/21.7.3/bin/node) npm : 10.8.2 OS : macOS Unknown

Additional Information

No response

brandyscarney commented 2 months ago

Thank you for the issue! I have moved this to the stencil-ds-output-targets repository since this is the repository that caused this issue. We have an internal issue to investigate this further.

tanner-reits commented 2 months ago

@mrsamse We've reverted the version of the React output target used in Ionic Framework as a part of the v8.2.9 and v8.3.1 releases to resolve this issue. I also updated the output target release notes to call this out as a breaking change.

Thank you for letting us know!

ionitron-bot[bot] commented 1 month ago

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of the output targets, please create a new issue and ensure the template is fully filled out.