ionic-team / stencil-ds-output-targets

These are output targets that can be added to Stencil for React and Angular.
https://stenciljs.com
MIT License
251 stars 117 forks source link

Added overrides to boolean and number value accessor as they don't wo… #514

Closed CosmicEvil closed 3 weeks ago

CosmicEvil commented 3 weeks ago

When adding the value accessors for boolean and number, we are getting errors about the overrides not being there. I added them in this commit, as without they won't compile.

christian-bromann commented 3 weeks ago

I added them in this commit, as without they won't compile.

Can you help me understand where it is not compiling? I don't see any issues within the build. (Please excuse me if this is a naive question as I haven't worked much with the Angular output target yet.)

CosmicEvil commented 3 weeks ago

@christian-bromann Sorry i didn't explain it well enough i think. I can't link to the actual codebase where the issue occurs, as it's a private one, but the gist of it is that i am trying to add those accessors and When adding the Boolean and number one, the error in the issue occurs on build:

image

I added the overrides to these functions in my "local" version of the npm package, and this fixed the issue, but it is necessary that the fix will also be in the package itself. If you want i can take the time tomorrow to set up a whole new repo that recreates the issue, but this might take a bit of time :) Thanks in advance!

CosmicEvil commented 3 weeks ago

It seems like you made the changes in our example projects, not in the actual Angular output target. Can we make the changes in the actual output target, here, here and maybe here too?

Added! The last one was not necessary, as that is the one that is overridden.

Samg983 commented 2 weeks ago

@christian-bromann , any idea when there will be a new release of the output target package?

christian-bromann commented 2 weeks ago

@Samg983 this patch should be already be released. We are working on improving the release pipeline to create better changelogs moving forward.