ionic-team / stencil-ds-output-targets

These are output targets that can be added to Stencil for React and Angular.
https://stenciljs.com
MIT License
250 stars 116 forks source link

bug: Missing overrides in angular value accessors #515

Open CosmicEvil opened 2 hours ago

CosmicEvil commented 2 hours ago

Prerequisites

Stencil Version

18.0.0

Stencil Framework Output Target

Angular

Stencil Framework Output Target Version

0.9.0

Current Behavior

When adding the value accessors for boolean and number, we are getting errors about the overrides not being there. This is due to the accessors having a function that overrides something in the parent accessor but is not noted as override.

Expected Behavior

The build should succeed instead of giving issues.

Steps to Reproduce

1) Add new value accessors for angular in the stencil config. 2) Specifically for the boolean and number 3) When building the angular stencil output it breaks

Code Reproduction URL

https://github.com/CosmicEvil/stencil-ds-output-targets

Additional Information

No response

ionitron-bot[bot] commented 2 hours ago

Thanks for the issue!

This project is currently maintained for the purposes of supporting Ionic Framework. At this time, only new issues & pull requests that support Ionic Framework will be prioritized. For the latest updates regarding the maintenance status of this project, please see this section of the project's README