ionic-team / stencil-sass

Sass plugin for Stencil
https://www.npmjs.com/package/@stencil/sass
Other
75 stars 23 forks source link

chore(build): improve build process #461

Closed christian-bromann closed 7 months ago

christian-bromann commented 8 months ago

Pull request checklist

Please check if your PR fulfills the following requirements:

Pull request type

Please check the type of change your PR introduces: - [ ] Bugfix - [ ] Feature - [ ] Refactoring (no functional changes, no api changes) - [x] Build related changes - [ ] Documentation content changes - [ ] Other (please describe): ## What is the current behavior? To build this project, there were two separate steps: compiling TypeScript and bundling through Rollup. I was running into some confusion as to why the `npm run watch` flag wouldn't work when having the tests running. Reason: the TS step would compile into ESM and not CJS which is later done by Rollup. ## What is the new behavior? By adding the TypeScript Rollup plugin we can do two steps in one. This also removes the some of the typescript compiled files that were not exported by the package. ## Does this introduce a breaking change? - [ ] Yes - [ ] No

Testing

n/a

Other information

n/a