search

ionic-team / stencil

A toolchain for building scalable, enterprise-ready component systems on top of TypeScript and Web Component standards. Stencil components can be distributed natively to React, Angular, Vue, and traditional web developers from a single, framework-agnostic codebase.
https://stenciljs.com
Other
12.52k stars 782 forks source link

Preamble config option doesn't work #2169

Closed danschultz closed 2 years ago

danschultz commented 4 years ago

Stencil version:

 @stencil/core@1.8.1

I'm submitting a:

[x] bug report [ ] feature request [ ] support request => Please do not submit support requests here, use one of these channels: https://stencil-worldwide.herokuapp.com/ or https://forum.ionicframework.com/

Current behavior: Specifying a preamble value in my Stencil config doesn't show up in my JS bundle.

Expected behavior: The main JS bundle in ./dist should contain the preamble value set in Stencil's config.

Steps to reproduce: Set the preamble in your stencil.config.ts file. Something like:

export const config: Config = {
  preamble: "Test preamble"
}

Run npm run build.

Related code:

// insert any relevant code here

Other information: Issue was previously reported with in https://github.com/ionic-team/stencil/issues/1723 but was closed due to inactivity.

https://stenciljs.com/docs/config#preamble

simonhaenisch commented 4 years ago

https://github.com/ionic-team/stencil/blob/d04fb902bfd3e0834e59677e15a5cd0710fc802c/src/utils/util.ts#L91

is still not used.

donskov commented 4 years ago

Hello. Any progress?

dutscher commented 3 years ago

why this is still ignored? this is also reported here last year: https://github.com/ionic-team/stencil/issues/1723

cheers

inspector gadget:

@adamdbradley committed on 3 Jun 2019: https://github.com/ionic-team/stencil-site/commit/1263d1e6fcf493f371e49d85832c9b24c378515d#diff-689c19470ae2ed5ac0b4ba2bb534871dd960e99ae1638ca7da6bab934a5dd022R106

cgpro commented 3 years ago

It would be great if the fix will be merged!

rwaskiewicz commented 2 years ago

This was fixed in https://github.com/ionic-team/stencil/pull/3085, and should be available in the next release of Stencil

rwaskiewicz commented 2 years ago

I'm going to close this issue, as v2.9.0 of Stencil resolves this issue. Please feel free to open a new issue if you feel the current functionality doesn't meet your expectations!