search

ionic-team / stencil

A toolchain for building scalable, enterprise-ready component systems on top of TypeScript and Web Component standards. Stencil components can be distributed natively to React, Angular, Vue, and traditional web developers from a single, framework-agnostic codebase.
https://stenciljs.com
Other
12.54k stars 784 forks source link

ion-content fullscreen freezes the prerender process #2429

Closed HaythemSahbani closed 1 year ago

HaythemSahbani commented 4 years ago

Stencil version:

 @stencil/core@1.12.7

I'm submitting a:

[x] bug report [ ] feature request [ ] support request => Please do not submit support requests here, use one of these channels: https://stencil-worldwide.herokuapp.com/ or https://forum.ionicframework.com/

Current behavior:

Hi I am trying to prerender the ionic-stencil starter app. However when adding fullscreen to the ion-content element the prerender process becomes inresponsive and I have to manually kill the process. Expected behavior:

The prerendering process doesn't freez Steps to reproduce:

  1. Run npm init stencil, (choose the ionic pwa)
  2. in the generated home.tsx file add fullscreen={true} or fullscreen to the ion-content
  3. Build with prerender, npm run build -- --prerender Related code:
// insert any relevant code here

Other information:

corysmc commented 4 years ago

+1 I just ran into this issue myself! - repro steps outlined above

tricki commented 4 years ago

Same here. After some debugging I discovered what seems to be an infinite loop that keeps rendering the ion-content indefinitely. Confirmed by logging calls to updateComponent.

cptflammin commented 3 years ago

Same here. Really problematic as a pretty important property in an app design ! Any update ?

splitinfinities commented 3 years ago

Could folks update to the latest versions of Stencil and Framework and help me understand if this still exists? It would be super helpful as well if we could get a GitHub repo with the recreation steps so we can quickly identify and resolve the issue.

tricki commented 3 years ago

I just created a new project (npm init stencil), added fullscreen={true} and configured a base URL and can reproduce the bug. Here's the repo (with VS Code prerender launch configured): https://github.com/tricki/stencil-fullscreen-prerender-bug Just run npm run build --prerender to reproduce it.

I still see updateComponent being called in an endless loop for ion-content. Here's the call stack (note updateComponent at the top and bottom):

image

rwaskiewicz commented 1 year ago

Hey folks. A fix for this issue was released as a part of Ionic Framework v7.0.6. As a result, I'm going to close out this issue. If this issue should reappear, please feel free to open a new issue. Thanks!