search

ionic-team / stencil

A toolchain for building scalable, enterprise-ready component systems on top of TypeScript and Web Component standards. Stencil components can be distributed natively to React, Angular, Vue, and traditional web developers from a single, framework-agnostic codebase.
https://stenciljs.com
Other
12.56k stars 785 forks source link

performance gains with jest-screenshot vs jest-image-screenshot #2935

Open klh opened 3 years ago

klh commented 3 years ago

I'm submitting a:

[ ] bug report [x] feature request [ ] support request => Please do not submit support requests here, use one of these channels: https://stencil-worldwide.herokuapp.com/ or https://forum.ionicframework.com/

currently stencil uses jest-image-snapshot internally to generate screenshots this could potentially be replaced by https://www.npmjs.com/package/jest-screenshot instead for significant performance gains - the 2 libraries have the same API

splitinfinities commented 3 years ago

Hey there, thank you for the patience getting back to you. The new team is getting started and we're working through the backlog now.

This is an interesting idea! We're going to investigate this. In the interim, if folks can 👍 this, we'd better understand what folks in the community want.

klh commented 2 years ago

I personally would actually like to remove the bundling completely, make stencil do its own thing and let jest do its thing. So instead of proxying jest through the stencil cli command - perhaps just create a jest setup that can be used as an example?

I know its a "Selling feature" - but i'd much prefer stencil to be a simpler step instead of "the kitchen sink"

That also opens up for you to just jettison all the puppeteer stuff and give examples for using jest or webdriver.io or xxx - seems a lot cleaner and easier for you to maintain.